add assertion helpers - #5
Conversation
| <!-- PDF --> | ||
| <dependency> | ||
| <groupId>org.apache.pdfbox</groupId> | ||
| <artifactId>pdfbox</artifactId> | ||
| <version>3.0.3</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.xhtmlrenderer</groupId> | ||
| <artifactId>flying-saucer-pdf</artifactId> | ||
| <version>9.9.4</version> | ||
| </dependency> | ||
|
|
||
| <!-- DOCX / XLSX --> | ||
| <dependency> | ||
| <groupId>org.apache.poi</groupId> | ||
| <artifactId>poi-ooxml</artifactId> | ||
| <version>5.3.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
I personally would not add it.
There was a problem hiding this comment.
It only adds those dependencies to the test code because this library gets imported with scope test. Flying Saucer is unnecessary indeed. I will remove it.
There was a problem hiding this comment.
PDF is quite common, maybe that is used in most projects, and could therefore be added, would not add the other two... nevertheless, we could have separate libs to handle such files, and those libs could then have testing tools.
There was a problem hiding this comment.
Ok, I'll consider this PR to be rejected and close it then.
There was a problem hiding this comment.
Not sure about that, would add the PDF assert in the meantime, until we have a dedicated lib... wdyt?
4 participants
No description provided.